Skip to content

Update gdb & Victor's guide links, and fix voters link ignore #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2023
Merged

Update gdb & Victor's guide links, and fix voters link ignore #1051

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aae754e
[PATCH]#1044 fixing victor stinner's guide link
Dev-satish Feb 10, 2023
549793f
fixed conf.py and advanced-tools/gdb.rst link issues
Dev-satish Feb 10, 2023
9942b41
changes made in gbd.rst
Dev-satish Feb 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion advanced-tools/gdb.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ GDB 7 and later
===============

In gdb 7, support for `extending gdb with Python
<https://sourceware.org/gdb/current/onlinedocs/gdb/Python.html#Python>`_ was
<https://sourceware.org/gdb/onlinedocs/gdb/Python.html#Python>`_ was
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need the #Python bit. There is an anchor on the page, but it's right at the top.

Suggested change
<https://sourceware.org/gdb/onlinedocs/gdb/Python.html#Python>`_ was
<https://sourceware.org/gdb/onlinedocs/gdb/Python.html>`_ was

added. When CPython is built you will notice a ``python-gdb.py`` file in the
root directory of your checkout. Read the module docstring for details on how
to use the file to enhance gdb for easier debugging of a CPython process.
Expand Down
2 changes: 1 addition & 1 deletion conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@

linkcheck_ignore = [
# The voters repo is private and appears as a 404
'https://github.com/python/voters/',
'https://github.com/python/voters',
# The python-core team link is private, redirects to login
'https://github.com/orgs/python/teams/python-core',
# The Discourse groups are private unless you are logged in
Expand Down
2 changes: 1 addition & 1 deletion getting-started/setup-building.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ You can run the build of Python you've compiled with:
See the `PCBuild readme`_ for more details on what other software is necessary
and how to build.

.. _Victor Stinner's guide: https://cpython-core-tutorial.readthedocs.io/en/latest/build_cpython_windows.html
.. _Victor Stinner's guide: https://web.archive.org/web/20220907075854/https://cpython-core-tutorial.readthedocs.io/en/latest/build_cpython_windows.html
.. _Visual Studio: https://visualstudio.microsoft.com/
.. _PCBuild readme: https://github.com/python/cpython/blob/main/PCbuild/readme.txt
.. _Git for Windows download from the official Git website: https://git-scm.com/download/win
Expand Down