-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Use type(x) == T for type narrowing #10284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JukkaL
merged 15 commits into
python:master
from
pranavrajpal:use-type-calls-for-narrowing
Apr 12, 2021
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
90ce4cd
Use type(x) == T for type narrowing
pranavrajpal 59eefe0
Avoid type narrowing in the else case
pranavrajpal c65c05a
Fix some flake8 errors
pranavrajpal 86034c9
Move check for type(x) == T to new function
pranavrajpal 9e2c246
Don't narrow if multiple types found
pranavrajpal eda0d03
Avoid narrowing if no type calls found
pranavrajpal de398dc
Fix type signature and documentation
pranavrajpal 5b8ef0b
Add type is not equal tests
pranavrajpal 5c98181
Fix "Unsupported left operand type" error in tests
pranavrajpal 2c83c0e
Narrow types in else case if type is final
pranavrajpal 275ee7a
Fix KeyError when looking up type info
pranavrajpal a055d4f
Fix AssertionError in lookup_typeinfo
pranavrajpal aa9f345
Catch all exceptions in lookup_typeinfo
pranavrajpal 7c37fe5
Rename final test using is not
pranavrajpal 372544f
Improve check if class is final
pranavrajpal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add also test case where you narrow from
Union[int, str]
toint
, and there is an else block. For example, something like this:The else block should use the original type, since instances of
int
subclasses (e.g.bool
) will be handled in the else block.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have added a test case for this and modified the type checker to handle this. Could you take a look at my changes when you get the chance?