Fix inference of IntEnum value attribute type #10412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
approved these changes
May 4, 2021
Co-authored-by: Jelle Zijlstra <[email protected]>
JukkaL
added a commit
that referenced
this pull request
May 4, 2021
The enum stubs for Python 2 are slightly different from Python 3. The fix in #10412 didn't quite work in Python 2 mode, since `IntEnum` doesn't define `__new__`, and the `__new__` from `builtins.int` is found instead. Work around this by skipping any `__new__` methods found in built-in types. I gave up trying to write a test case for this. It's tricky because `enum` is in Python 3 stdlib but not in Python 2 stdlib.
JukkaL
added a commit
that referenced
this pull request
May 4, 2021
The enum stubs for Python 2 are slightly different from Python 3. The fix in #10412 didn't quite work in Python 2 mode, since `IntEnum` doesn't define `__new__`, and the `__new__` from `builtins.int` is found instead. Work around this by skipping any `__new__` methods found in built-in types. I gave up trying to write a test case for this. It's tricky because `enum` is in Python 3 stdlib but not in Python 2 stdlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the enum value initializer has a NewType type, it should be
reflected in the type of the
valueattribute. It was broken becausethe special casing for
__new__introduced in #10057 didn't considerthe
__new__inIntEnumas special.Fixes #10411.