Sync typeshed #10924
Merged
Sync typeshed #10924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source commit: python/typeshed@b2e429c
|
Diff from mypy_primer, showing the effect of this PR on open source code: pip (https://github.com/pypa/pip.git)
+ src/pip/_internal/locations/__init__.py:60: error: unused "type: ignore" comment
+ src/pip/_internal/locations/__init__.py:72: error: unused "type: ignore" comment
+ src/pip/_internal/utils/unpacking.py:200: error: unused "type: ignore" comment
werkzeug (https://github.com/pallets/werkzeug.git)
+ src/werkzeug/debug/console.py:146: error: Argument 1 to "register" of "_ConsoleLoader" has incompatible type "Optional[CodeType]"; expected "CodeType"
+ src/werkzeug/debug/console.py:147: error: Incompatible return value type (got "Optional[CodeType]", expected "CodeType")
+ src/werkzeug/debug/console.py:149: error: Incompatible types in assignment (expression has type "Callable[[str, str, str], CodeType]", variable has type "CommandCompiler")
- tests/test_wrappers.py:355: note: Use "-> None" if function does not return a value
- tests/test_wrappers.py:362: error: Function is missing a return type annotation
- tests/test_wrappers.py:363: error: Function is missing a type annotation
- tests/test_wrappers.py:370: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
+ tests/test_wrappers.py:355: note: (Skipping most remaining errors due to unresolved imports or missing stubs; fix these first)
starlette (https://github.com/encode/starlette.git)
+ starlette/routing.py:84: error: <nothing> has no attribute "__name__"
spark (https://github.com/apache/spark.git)
+ python/pyspark/pandas/typedef/typehints.py:526: error: Argument 3 to "DataFrameType" has incompatible type "List[None]"; expected "List[Optional[str]]"
+ python/pyspark/pandas/typedef/typehints.py:526: note: "List" is invariant -- see https://mypy.readthedocs.io/en/stable/common_issues.html#variance
+ python/pyspark/pandas/typedef/typehints.py:526: note: Consider using "Sequence" instead, which is covariant
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source commit:
python/typeshed@b2e429c