[mypyc] Use native calls to singledispatch functions #10981
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypyc doesn't have support for calling callable classes without going through the python API, so instead of having to special case the singledispatch callable class when we want to generate a native call to it, we create a glue function that loads the callable class from the globals dict and then makes a native call to that callable class's __call__ method.
Use a native call to the glue function that we generate for singledispatch functions instead of calling those singledispatch functions through the python API.
Add an irbuild test to make sure we use native calls to the glue functions for singledispatch functions, and that the glue functions make native calls to the __call__ methods on the callable classes.
msullivan
approved these changes
Aug 16, 2021
|
I love the speedup! |
sthagen
added a commit
to sthagen/python-mypy
that referenced
this pull request
Aug 16, 2021
[mypyc] Use native calls to singledispatch functions (python#10981)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#881
This makes generated code use native calls to singledispatch functions whenever possible, which makes singledispatch functions faster.
Benchmark results
This PR:
Current master (4c90aa4):
Test Plan
I added an irbuild test to make sure that we were using native calls to singledispatch functions.