-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Check Enum
definition for invalid base classes
#12026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Something off-topic: the |
There are quite a lot of stateless methods that we can extract like new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! Sorry for the slow response, I'm slowly getting back to mypy code reviews.
We can split The key would be to identify groups of related functionality that make sense to be moved away to a new module. Just moving random bits and pieces to another module doesn't improve the situation much. The |
Checks in Python's source:
Enum
base: https://github.com/python/cpython/blob/d05a66339b5e07d72d96e4c30a34cc3821bb61a2/Lib/enum.py#L971-L974Closes #11948