Skip to content

Allow semantic analyzer errors to be suppressed with # type: ignore #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2016

Conversation

ddfisher
Copy link
Collaborator

This lets users work around #1304 for now by repeating the full concretization of parent types in child subclasses and adding a # type: ignore.

@JukkaL
Copy link
Collaborator

JukkaL commented Mar 18, 2016

Please add some test cases for common things that you believe people might want to ignore. Also if an ignored line defines something, it would be good to check that accessing that later doesn't generate another error (then ignoring the first error wouldn't be very helpful).

@ddfisher
Copy link
Collaborator Author

Added a unit test for the test case we care about.

gvanrossum added a commit that referenced this pull request Mar 18, 2016
Allow semantic analyzer errors to be suppressed with # type: ignore
@gvanrossum gvanrossum merged commit e6ba756 into python:master Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants