-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix nondeterministic type checking by making join with explicit Protocol and type promotion commute #18402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
Hmm, false positive is because |
This comment has been minimized.
This comment has been minimized.
cc @JukkaL one more nondeterminism PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good overall, though the logic is getting pretty hard to follow. Left some comments about tests.
Diff from mypy_primer, showing the effect of this PR on open source code: nox (https://github.com/wntrblm/nox): 1.46x slower (24.6s -> 35.9s in single noisy sample)
typeshed-stats (https://github.com/AlexWaygood/typeshed-stats): 1.57x slower (60.7s -> 95.0s in single noisy sample)
|
Fixes #16979 (bzoracler case only, OP case fixed by #19147)
See #16979 (comment)