[mypyc] Using UnboundedType to access class object of a type annotation. #18874
+66
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advait-dixit
changed the title
JukkaL
reviewed
Apr 8, 2025
| @@ -78,17 +78,22 @@ assert hasattr(c, 'x') | |||
|
|
|||
| [case testTypedDictWithFields] | |||
| import collections | |||
| import json | |||
There was a problem hiding this comment.
What if as is used in the import, such as import json as _json? There could even be a case like this:
import a as b
import b as a
...
# b.C in an annotation refers to fullname a.C!Similarly, what if we have from pkg import submod and then submod.C is used in an annotation?
It's okay to not support all possible cases yet -- we can create follow-up issues -- but it would be nice if we can avoid having references to incorrect types.
| @@ -802,15 +802,41 @@ def get_func_target(builder: IRBuilder, fdef: FuncDef) -> AssignmentTarget: | |||
| return builder.add_local_reg(fdef, object_rprimitive) | |||
|
|
|||
|
|
|||
| def load_type(builder: IRBuilder, typ: TypeInfo, line: int) -> Value: | |||
| def load_type(builder: IRBuilder, typ: TypeInfo, unbounded_type: Type | None, line: int) -> Value: | |||
| # typ.fullname contains the module where the class object was defined. However, it is possible that the class | |||
There was a problem hiding this comment.
Style nit: some of the comments seem to be longer than 99 characters, which is our line length limit. Can you wrap any long lines?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mypyc/mypyc#1087.
This fix handles cases where type annotation is nested inside an imported module (like an inner class) or imported from a different module.