Phase 2 of async/await #1946
Merged
Phase 2 of async/await #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2016
Closed
gvanrossum
force-pushed
the
add-crawl2-reborn
branch
from
520a431 to
d0f7a5e
Compare
| @@ -61,6 +62,9 @@ class Awaitable(Generic[T]): | |||
| @abstractmethod | |||
| def __await__(self) -> Generator[Any, Any, T]: pass | |||
|
|
|||
| class AwaitableGenerator(Generator[T, U, V], Awaitable[V], Generic[T, U, V, S]): | |||
There was a problem hiding this comment.
Why is there an AwaitableGenerator in the test data typing stub when there isn't one in the real typing module?
There was a problem hiding this comment.
Because this stub (despite its extension) is actually a stub. It matches the real typing.pyi, not any real typing.py.
There was a problem hiding this comment.
Oh okay. That makes sense.
gvanrossum
force-pushed
the
add-crawl2-reborn
branch
from
30e1a4a to
77f2ba2
Compare
| self.lookup_qualified('typing.AwaitableGenerator') | ||
| except KeyError: | ||
| return False | ||
| agt = self.named_generic_type('typing.AwaitableGenerator', |
There was a problem hiding this comment.
Wouldn't it be simpler to just look at the fullname instead, like we do elsewhere?
added 2 commits
August 3, 2016 16:28
Both crawl.py and crawl2.py pass cleanly now!
| else: | ||
| # `return_type` is a supertype of Generator, so callers won't be able to send it | ||
| # values. | ||
| # Supertype of Generator (Iterator, Iterable, object), tc is None. |
There was a problem hiding this comment.
I think the bit of motivation is worthwhile here too.
added 15 commits
August 3, 2016 16:32
Mostly streamlined the comments, but also decided that return in a generator not explicitly declared as returning Any or Generator should be None.
NOTE: the Matrix test is currently failing.
Upgrade AwaitableGenerator to four parameters -- the last one preserves the original type, which we sometimes need.
added 6 commits
August 3, 2016 16:32
gvanrossum
force-pushed
the
add-crawl2-reborn
branch
from
77f2ba2 to
839dc7d
Compare
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for decorating either generators or
async deffunctions with@types.coroutineor@asyncio.coroutine. This will fix #1453.