Various fixes to the fine-grained incremental mode #4438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundling these in a single commit since a single test case reproduces both of these issues and initially it wasn't clear if they are a single issue. 1. Fix AST merge of ClassDefs. 2. If there is a previous error in a class body, refresh module top level instead of the whole class. 3. Generally fix the previous target handling in case of nested definitions (full test coverage missing).
Not sure if this will make a difference anywhere, but this seems like the right thing to do.
TODO: Add test case
I didn't add tests since it's unclear if these actually caused any visible issues.
Not sure if these changes fix user-visible issues, but this at least makes things cleaner.
Not sure if this fixes an user-visible issue, but at least this makes things more consistent.
msullivan
reviewed
Jan 9, 2018
| @@ -129,10 +129,20 @@ class Errors: | |||
| # Set to True to show column numbers in error messages. | |||
| show_column_numbers = False # type: bool | |||
|
|
|||
| # Stack of active fine-grained incremental checking targets within | |||
| # a module. The first item is always the current module id. | |||
| # State for keeping track of the current fine-grained incremental mode target. | |||
There was a problem hiding this comment.
Is Errors the best place to be tracking what target is currently being processed?
There was a problem hiding this comment.
Not really. Errors is tracking this primarily for convenience -- it's the only place that currently has enough context and is available pretty much everywhere. A better approach might be to have a separate context class which would track the current scope and target, and Errors would get access to this context (but it would only need read-only access). Since this PR doesn't change the responsibilities of Errors significantly (the wart was already there before), I'd prefer to refactor this in a separate PR.
msullivan
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fix various issues seen when testing with real-world code.