Fix two crashes in duplicate decorated functions #5427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops pushed too soon. Will fix the failures in other tests now. |
msullivan
approved these changes
Aug 8, 2018
| @@ -427,17 +427,24 @@ class OverloadedFuncDef(FuncBase, SymbolNode, Statement): | |||
| """ | |||
|
|
|||
| items = None # type: List[OverloadPart] | |||
| unanalyzed_items = None # type: List[OverloadPart] | |||
There was a problem hiding this comment.
I really don't love all these unanalyzed things that aststrip forces upon us. Oh well.
There was a problem hiding this comment.
I tried few other solutions, but after few attempts to undo the logic of deleting overloads in second pass, I just went with this, although I don't like this either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5394
Fixes #5181
The problem is that duplicate decorated functions are parsed as
OverloadedFuncDefeven if the actual decorator used is nottyping.overload. This PR fixes possible crashes related to this. I could imagine there may be some extra spurious errors in some scenarios (in addition to duplicate definition correctly reported by mypy), but at least it should not crash.