Various fixes to following imports in mypy daemon #8590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow alternate path separate on Windows. Recognize `__init__.pyi` files.
|
The travis build seems to have passed, but it's not reflected here. |
msullivan
approved these changes
Mar 30, 2020
| @@ -720,6 +741,9 @@ def pretty_messages(self, messages: List[str], n_sources: int, | |||
|
|
|||
| def update_sources(self, sources: List[BuildSource]) -> None: | |||
| paths = [source.path for source in sources if source.path is not None] | |||
| if self.following_imports(): | |||
There was a problem hiding this comment.
I don't follow this really?
There was a problem hiding this comment.
If there are directories in paths, we'll get exceptions inside fswatcher.
JukkaL
added a commit
that referenced
this pull request
Apr 3, 2020
This includes a bunch of changes to following imports: * Fix bug with cached modules without ASTs by loading the AST as needed * Improve docstrings and simplify code * Rename `follow_imports` * Merge `seen` and `sources_set` * Address some TODO items This may be easier to review by looking at individual commits. I think that following imports is ready to be enabled after this has been merged. We can always revert the change before the next release if we we encounter major issues. Major things I know about that still don't work (I'll try to address at least the first one before the next release): * `-m` and `-p` don't work correctly with dmypy (I think that happens also in other modes, but might be worse when following imports) * Suppressed modules are incorrect with namespace modules (happens also in other modes) * File events are not supported (but these are undocumented, so it's not critical?) * Performance with a huge number of files is unknown (other import modes have better performance and can be used as fallbacks if this is a problem) Work towards #5870. Continues progress made in #8590.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included fixes:
/path separators on WindowsNamespace package support is not complete, but the issue I found isn't
specific to following imports in mypy daemon, so I didn't try to fix it
in this PR. I'll create a follow-up issue.