Skip to content

PEP 605: fix footnotes #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2022
Merged

PEP 605: fix footnotes #2743

merged 2 commits into from
Jul 29, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jul 28, 2022

Fix these warnings:

pep-0605.rst:1346: WARNING: Footnote [1] is not referenced.
pep-0605.rst:1349: WARNING: Footnote [2] is not referenced.
pep-0605.rst:1352: WARNING: Footnote [3] is not referenced.
pep-0605.rst:1355: WARNING: Footnote [4] is not referenced.
pep-0605.rst:1358: WARNING: Footnote [5] is not referenced.
pep-0605.rst:1361: WARNING: Footnote [6] is not referenced.

References should be like [5]_ not [5_].

Also remove redundant emacs metadata.

@hugovk hugovk added the bug label Jul 28, 2022
@hugovk hugovk requested review from zooba and ncoghlan as code owners July 28, 2022 11:48
CAM-Gerlach
CAM-Gerlach approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

@hugovk hugovk merged commit c75fd8f into python:main Jul 29, 2022
@hugovk hugovk deleted the pep605-fix-footnotes branch July 29, 2022 09:46
@hugovk hugovk mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@zooba zooba Awaiting requested review from zooba

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @CAM-Gerlach