Skip to content

PEP 532, 577, 598: Fix footnotes references #2791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 14, 2022
Merged

PEP 532, 577, 598: Fix footnotes references #2791

merged 7 commits into from
Sep 14, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 12, 2022 •
edited
Loading

Fix footnote references: instead of [1_] should be of the form [1]_:

pep-0532.txt:886: WARNING: Footnote [1] is not referenced.
pep-0532.txt:889: WARNING: Footnote [2] is not referenced.
pep-0532.txt:892: WARNING: Footnote [3] is not referenced.
pep-0577.rst:806: WARNING: Footnote [1] is not referenced.
pep-0577.rst:809: WARNING: Footnote [2] is not referenced.
pep-0577.rst:812: WARNING: Footnote [3] is not referenced.
pep-0577.rst:815: WARNING: Footnote [4] is not referenced.
pep-0598.rst:885: WARNING: Footnote [1] is not referenced.
pep-0598.rst:888: WARNING: Footnote [2] is not referenced.
pep-0598.rst:891: WARNING: Footnote [3] is not referenced.

Also remove redundant emacs metadata, update a link redirect and fix a typo.

Preview

@hugovk hugovk added the bug label Sep 12, 2022
@hugovk hugovk requested a review from ncoghlan as a code owner September 12, 2022 15:33
CAM-Gerlach
CAM-Gerlach reviewed Sep 14, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

CAM-Gerlach
CAM-Gerlach approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @hugovk

@hugovk hugovk merged commit 01473dc into python:main Sep 14, 2022
@hugovk hugovk deleted the pep532-577-598-fix-footnotes branch September 14, 2022 08:35
@hugovk hugovk mentioned this pull request Jan 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @CAM-Gerlach