-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 366, 395, 413, 426, 430, 440, 531, 535, 3150: Fix footnotes #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…emove redundant emacs metadata
…nt emacs metadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked through the source changes and spot checked the rendered versions and they LGTM overall, but the bulleted inline-linked items did look kind of strange alongside the numbered footnotes with raw links. Its not perfect (we probably should also tweak the vertical margins of things at some point, not just here but a few other places could use them too), but converting the footnotes that are just links with a title to actual inline links improves this a lot and makes them more consistent and coherent, as well as being cleaner and taking up less space overall. Do you think you could do that at least for the ones where you added bulleted references?
vs.
Good idea, I'll update them. |
d42816b
to
63b9008
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks pretty good—one thing though, the interleaved bullets and footnotes are a little confusing to me, as it looks like the bulleted items are sub-items of the footnotes. Could you maybe just move the non-numbered footnote bulletted items to the end after the footnotes?
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @hugovk !
Thanks for the reviews! |
Fix these warnings:
Details
PEP 366:
PEP 395:
PEP 413:
PEP 426:
PEP 430:
PEP 440:
PEP 531:
PEP 535:
PEP 3150:
Previews