-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Infra: Check Sphinx warnings on CI #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It found one! #3189 was merged since I branched :) |
See #3214 to resolve several warnings. |
The only outstanding warnings are now unreferenced footnotes, of which we have 59 across 40 files: Full list
A |
AA-Turner
reviewed
Jul 31, 2023
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
I've opened a first batch of 10 PRs to resolve PEPs 232 through 340. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to what we have in the CPython repo, most recently: python/cpython#106460, and will help us gradually remove Sphinx warnings, and avoid new ones being introduces.
It checks three things:
If a file previously had no warnings (not listed in
.nitignore
), and new ones are introduced, it failsIf a file previously had warnings (it's lsited in
.nitignore
), but now has none, it fails and tells us to remove it from.nitignore
If a file previously had warnings (it's listed in
.nitignore
), and still has warnings, it doesn't fail, but it will annotate the PR to show the warningI've intentionally kept the code and layout as close as possible to the CPython version (see https://github.com/python/cpython/tree/main/Doc/tools) for easier future maintenance.
📚 Documentation preview 📚: https://pep-previews--3213.org.readthedocs.build/