Skip to content

Added another step on contributing.md to avoid pip install issue #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

mgiannopoulos24
Copy link
Contributor

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes #569

Περιγραφή του PR

Προστέθηκε ένα επιπλέον βήμα στο CONTRIBUTING.md το οποίο θα μας συμβουλεύει να χρησιμοποιήσουμε και το παρακάτω command ώστε να κάνουμε clone και το cpython ολόκληρο.

git submodule update --init

@mgiannopoulos24 mgiannopoulos24 requested a review from a team as a code owner December 9, 2024 10:58
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgiannopoulos24! Έκανα 2 comments για κάποια improvements. Ψιλό-άσχετα με το συγκεκριμένο PR, οπότε αν θες να κάνουμε merge αυτό και δουλεύουμε στα points μου σε ένα καινούριο (αν θες, μπορώ να τα κάνω κι εγώ, ό,τι προτιμάς).

@mgiannopoulos24
Copy link
Contributor Author

εντάξει θα το φτιάξω εγώ.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mgiannopoulos24!

@lysnikolaou lysnikolaou merged commit 610850f into python:3.12 Dec 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty cpython directory after cloning.
2 participants