Skip to content

Make the theme responsive #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
May 7, 2021
Merged

Make the theme responsive #46

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
7aba474
Make theme responsive
obulat May 19, 2020
203b40a
Address code review issues
obulat Jun 19, 2020
10f4349
Use css for opening/closing menu
obulat Jul 9, 2020
ff61d60
Adjust font and selects
obulat Dec 21, 2020
7640739
Add language and version switcher placeholders
obulat Dec 25, 2020
ecf73cf
Remove duplicate rootrellink declaration
obulat Mar 9, 2021
43da2b4
Remove dublicate relbaritems block
obulat Apr 13, 2021
51a0c7a
Update select styles
obulat Apr 13, 2021
efd1ec2
Add missing select styles
obulat Apr 13, 2021
7953f1b
Change the search icon color
obulat Apr 13, 2021
6daa876
Change caret color
obulat Apr 13, 2021
250dbf6
Change hamburger color
obulat Apr 13, 2021
5ffa114
Add an svg icon
obulat Apr 13, 2021
e1ee8bd
Add svg logo to layout
obulat Apr 13, 2021
1e182f3
Merge remote-tracking branch 'upstream/master'
obulat May 2, 2021
611a1dc
Add switchers to desktop view
obulat May 2, 2021
783b19a
Fix toggler accessibility and select paddings
obulat May 2, 2021
d31371e
Fix html formatting
obulat May 2, 2021
190931b
Add link to homepage in mobile version
obulat May 5, 2021
b6fc448
Add smaller padding to toctree
obulat May 5, 2021
cd92c8c
Add a different link to the logo
obulat May 5, 2021
ed7b948
Make logo in mobile version link to 'http://0.0.0.0:8000/3.9/'
obulat May 5, 2021
d96713e
Make logo in mobile version link to 'http://0.0.0.0:8000/3.9/'
obulat May 5, 2021
bd1d802
Make logo in mobile version link to theme root
obulat May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python_docs_theme/layout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,10 @@ <h3>{{ _('Navigation') }}</h3>
<span></span>
</label>
<nav class="nav-content" role="navigation">
<img src="{{ pathto('_static/' + 'py.svg', 1) }}" alt="Logo"/>
<a href="{{ pathto('index') }}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pathto(master_doc) would be more appropriate here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or does CPython documentation use contents for the toctree?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for such a quick review! :) I know what I added doesn't work for sure. Let me try pathto(master_doc).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need help!
I don't know how to add the correct link to the docs.python.org/3.9/.
In line 88 in layout.html I added <a href="{{ pathto(theme_root_url) }}" , and it creates file:///.../doc-html(3)/3.9/https://www.python.org/.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't wrap it in pathto, just {{ theme_root_url }} is enough.

That should fix it. :)

Copy link
Member

@pradyunsg pradyunsg May 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, that is behaviour I'd expect and I thought that's what you wanted?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I was confusing the two kind of links (to the docs home and the language/framework home). On the sites I used a lot lately (eg Vue.js) the style of the framework home page and the style of the documentation homepage are the same. And it feels like I just go to the documentation home, not the general home, when I click on the logo.

But you are right, now we have the correct behavior, linking to python.org.

We still don't have a way of going to the documentation homepage, docs.python.org/3 from other pages on mobile. Is it necessary to add it, and add it in this PR specifically?

Copy link
Member

@pradyunsg pradyunsg May 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to have a link to the documentation homepage, that'd be {{ pathto(master_doc) }} or {{ pathto("index") }}. No need for a |e on either of them.

Copy link
Member

@pradyunsg pradyunsg May 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, this feels like something we can do in a follow up PR.

I'd really like to push for getting this landed soon, so that we can start moving other things forward without needing to come back and update this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, let me know if I need to change anything? I would be happy to get this landed soon, too!

<img src="{{ pathto('_static/' + 'py.svg', 1) }}" alt="Logo"/>
{{ shorttitle }}
</a>
<div class="version_switcher_placeholder"></div>
{%- if pagename != "search" and builder != "singlehtml" %}
<form id="searchbox" role="search" class="search" action="{{ pathto('search') }}" method="get">
Expand Down
4 changes: 4 additions & 0 deletions python_docs_theme/static/pydoctheme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,10 @@ dl > dt span ~ em {
font-family: monospace, sans-serif;
}

.toctree-wrapper ul {
padding-left: 20px;
}

@media (max-width: 1023px) {
/* Body layout */
div.body {
Expand Down