Skip to content

utime(), _extract_member() for tarfile.TarFile are absent #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mkurnikov opened this issue Dec 6, 2018 · 3 comments
Closed

utime(), _extract_member() for tarfile.TarFile are absent #2673

mkurnikov opened this issue Dec 6, 2018 · 3 comments
Labels
stubs: incomplete Annotations or sub-modules missing from an existing package or module

Comments

@mkurnikov
Copy link
Contributor

Encountered covering pip with stubs.

I can add PR, but I'm not sure whether they should be included in stubs, both are undocumented and second one is private.
@srittau
Copy link
Collaborator

srittau commented Dec 6, 2018

That utime() is not documented looks like an oversight to me. I'd probably accept it as stub (with either an # undocumented annotation or maybe a bpo documentation bug report). @gustaebel is listed as tarfile expert in the expert index and might have an opinion on that.

@srittau srittau added size-small stubs: incomplete Annotations or sub-modules missing from an existing package or module labels Dec 6, 2018
@python python deleted a comment from createza Dec 10, 2018
@rohitkg98
Copy link
Contributor

looks like utime() has been added to the stubs. Do we want to include private methods?

@JelleZijlstra
Copy link
Member

We can add private methods if users request them. I'm not sure we need to keep the issue open for that, but we'll accept a PR adding more private methods.

@srittau srittau closed this as completed Oct 12, 2020
@jdufresne jdufresne mentioned this issue Aug 2, 2021
Merged
srittau pushed a commit that referenced this issue Aug 3, 2021
@jdufresne
Add typing for TarFile._extract_member method (#5841)
b2e429c 
Refs: #2673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stubs: incomplete Annotations or sub-modules missing from an existing package or module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@srittau @JelleZijlstra @mkurnikov @rohitkg98