Skip to content

Stdlib modules removed in Python 3.13 (PEP 594) #11193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

lancelote
Copy link
Contributor

Set last available version for stdlib modules removed in Python 3.13 (deprecated in PEP 594)

@AlexWaygood
Copy link
Member

Thanks! We generally hold off on making this kind of change until the beta period, however, as things can change a lot during the alpha period (removed modules have often been added back during the alpha period after it was found that their removal caused too much disruption).

Having said that, when we start running stubtest on py313 in CI, stubtest will emit an error if it finds that any of these modules do in fact still exist, so it shouldn't cause any problems if we merge this now.

Not sure, what do other maintainers think?

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Avasam
Copy link
Collaborator

Avasam commented Dec 21, 2023

Given the small, CI testable, and backwards compatible nature of the changes. I don't see much harm in having it ahead of time. If it helps early testing of Python 3.13.

It's a bit more straightforward than added platform checks, which would be more annoying to revert.

So if you're fine knowing some of these might have to be added back once we start testing on Python 3.13 .


But that raises the question: are we "officially" moving the line (from beta to alpha) for stdlib removals? Or should we stick to a rigid "no changes until beta"?

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Dec 21, 2023

typeshed isn't really a rigid rules kind of project. The reason we try to keep to beta is that CPython has a habit of changing things, potentially in ways that stubtest cannot catch. But if a change isn't churn-y and we're confident stubtest will catch any later changes, like this one, there's no reason not to merge.

@hauntsaninja hauntsaninja merged commit c1137ee into python:main Dec 21, 2023
@lancelote lancelote deleted the lancelote/pep-594 branch December 21, 2023 12:29
@JelleZijlstra
Copy link
Member

Getting to this late, but we might want to move away from the rule to hold off until the beta, since there's now a lot more overlap between active typeshed and CPython maintainers than before.

@hauntsaninja
Copy link
Collaborator

Interesting point, but I still think beta is the appropriate time to set about updating things module by module. If you do this too early, you just end up having to do it again later or being okay with missing the things stubtest doesn't catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants