replace re patterns AnyStr with Union[str, unicode] #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Thanks! |
OrenLeaffer
pushed a commit
to OrenLeaffer/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
OrenLeaffer
pushed a commit
to OrenLeaffer/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
OrenLeaffer
pushed a commit
to OrenLeaffer/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
OrenLeaffer
pushed a commit
to OrenLeaffer/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
OrenLeaffer
added a commit
to OrenLeaffer/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
OrenLeaffer
added a commit
to OrenLeaffer/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
OrenLeaffer
added a commit
to OrenLeaffer/zulip
that referenced
this pull request
Jun 3, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
timabbott
pushed a commit
to zulip/zulip
that referenced
this pull request
Jun 4, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
|
I had to roll this back in fb96ee8. This PR introduced some bugs (it used |
TomaszKolek
pushed a commit
to TomaszKolek/zulip
that referenced
this pull request
Jul 6, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
TomaszKolek
pushed a commit
to TomaszKolek/zulip
that referenced
this pull request
Aug 25, 2016
Had to add some "type: ignore" because the pattern used in match doesn't affect the type returned. A fix for this issue has been pushed to typeshed - python/typeshed#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of the pattern doesn't affect the return type.