Fix various __all__ bugs and omissions
#7618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
commented
Apr 13, 2022
| # This is a slight lie, the implementations aren't exactly identical | ||
| # However, in all likelihood, the differences are inconsequential | ||
| from decimal import * | ||
|
|
||
| if sys.version_info >= (3, 7): | ||
| __all__ = [ |
There was a problem hiding this comment.
Surprisingly, _pydecimal appears to have __all__ even though decimal doesn't. ¯\_(ツ)_/¯
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
| @@ -82,15 +132,14 @@ TypedDict: object | |||
|
|
|||
| OrderedDict = _Alias() | |||
|
|
|||
| if sys.version_info >= (3, 7): | |||
There was a problem hiding this comment.
Technically we shouldn't do this because the change hasn't been released yet, but I don't want to have to duplicate __all__ here.
JelleZijlstra
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
typing_extensions.get_type_hints,typing_extensions.get_argsandtyping_extensions.get_originare "available" on Python 3.6 now thattyping_extensionshas dropped support for 3.6.