Remove un-needed __hash__
methods from stdlib
#8465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on stubs for
django
I've noticed that sometimes people redefine__hash__
.But, this is not what we do for other methods. For example, if base class
A
definesfoo
, its child classB
does not need to also definefoo
. Parent's definition will be used by default. We only annotate redefinitions.So,
__hash__
is defined inobject
. Child classes may not redefine it, unless:__hash__
returns something different, notint
(likeenum.Enum
does right now)__hash__
is set to beClassVar[None]
__hash__
is reset after parent'sClassVar[None]
to indicate that subclass is immutable again__hash__
is required to be set explicitly as a part of@abstractmethod
parent's def, likenumbers.Number
doesMypy sample: https://mypy-play.net/?mypy=latest&python=3.10&gist=cef2a15be8adfa8d646d260232e6b38a
What do others think?