Skip to content

[April 2023] D3DShot is an archived repo #8929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn marked this pull request as ready for review October 19, 2022 11:15
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 19, 2022

This one feels like a bit of a special case -- we only added these stubs a few weeks ago, and we knew it was archived at the time (see #8652 (comment), and following discussion).

It feels a bit harsh on @Avasam to delete the stubs from typeshed only a month after he put a lot of work into adding them!

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@sobolevn
Copy link
Member Author

Oh, I didn't notice that.

@srittau
Copy link
Collaborator

srittau commented Oct 19, 2022

Maybe we should delete them after six months if there haven't been major updates to the stubs since then? I'd expect possible kinks having been worked out by then, so the last published version on PyPi of the types should be in a good state by then.

@AlexWaygood
Copy link
Member

Maybe we should delete them after six months if there haven't been major updates to the stubs since then? I'd expect possible kinks having been worked out by then, so the last published version on PyPi of the types should be in a good state by then.

Yeah, that sounds like a good plan to me!

@srittau srittau added the status: deferred Issue or PR deferred until some precondition is fixed label Oct 19, 2022
@srittau srittau changed the title D3DShot is an archived repo [April 2023] D3DShot is an archived repo Oct 19, 2022
@AlexWaygood AlexWaygood marked this pull request as draft October 19, 2022 13:39
@AlexWaygood AlexWaygood removed the status: deferred Issue or PR deferred until some precondition is fixed label Apr 1, 2023
@AlexWaygood AlexWaygood marked this pull request as ready for review April 1, 2023 09:40
@AlexWaygood AlexWaygood merged commit 6a37fb0 into python:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants