Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.14 in CI #565

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Test Python 3.14 in CI #565

wants to merge 3 commits into from

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Apr 1, 2025

No description provided.

@srittau
Copy link
Collaborator Author

srittau commented Apr 1, 2025

Ideally I'd want to use something like continue-on-error: ${{ matrix.python-version == '3.14-dev' }}, but I don't think it's possible. (We could of course emulate this by changing the shell command, but I don't like that.)

@brianschubert
Copy link
Contributor

but I don't think it's possible.

I think it might be? I saw something similar in the SQLAlchemy tests: https://github.com/sqlalchemy/sqlalchemy/blob/main/.github/workflows/run-test.yaml#L121

@srittau
Copy link
Collaborator Author

srittau commented Apr 1, 2025

Huh, I tried that but VSCode flagged that as invalid and the GitHub docs didn't mention it. I'll change it.

@srittau srittau marked this pull request as ready for review April 1, 2025 13:13
@Daraan
Copy link
Contributor

Daraan commented Apr 2, 2025

@srittau
Copy link
Collaborator Author

srittau commented Apr 2, 2025

In principle I like the idea of a warning message, but I didn't want to complicate the CI scripts for now.

@brianschubert
Copy link
Contributor

Can/should we add a warning in a failing case?

I think we get this for free - it seems an error annotation still gets emitted for the failing step even when the job doesn't fail: https://github.com/python/typing_extensions/actions/runs/14196009731

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants