Fix get_type_hints() on x-module inherited TypedDict in 3.9 and 3.10 #94
+33
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in python/cpython#27017 was never backported into typing-extensions.
In 3.11 it doesn't matter because we just use
TypedDict
fromtyping.py
. But in 3.9 and 3.10, it means this cross-module inheritance scenario with stringified annotations andget_type_hints
will fail if you useTypedDict
fromtyping_extensions
but work if you use it fromtyping
.I don't attempt here to backport the fix to pre-3.9 versions where
typing.py
doesn't have it; that would require pulling in lots more code (ForwardRef
and some utility functions) intotyping_extensions.py
. Just aiming for parity withtyping.py
for 3.9 and 3.10.