Expose SE/DESE support to EmbeddingRocksDBWrapper for training pipeline #4227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D75489895 |
Raahul46
force-pushed
the
export-D75489895
branch
from
f27f0e1 to
499bfbd
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…ne (pytorch#4227) Summary: X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Differential Revision: D75489895
Raahul46
force-pushed
the
export-D75489895
branch
from
499bfbd to
9764393
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…ne (pytorch#4227) Summary: X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Differential Revision: D75489895
|
This pull request was exported from Phabricator. Differential Revision: D75489895 |
Raahul46
force-pushed
the
export-D75489895
branch
from
9764393 to
6547986
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…ne (pytorch#4227) Summary: Pull Request resolved: pytorch#4227 X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Differential Revision: D75489895
|
This pull request was exported from Phabricator. Differential Revision: D75489895 |
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 4, 2025
…ne (pytorch#4227) Summary: Pull Request resolved: pytorch#4227 X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Reviewed By: duduyi2013 Differential Revision: D75489895
Raahul46
force-pushed
the
export-D75489895
branch
from
6547986 to
28d3cc1
Compare
added 6 commits
June 4, 2025 16:47
Differential Revision: D75489819
Differential Revision: D75489827
Differential Revision: D75489841
Differential Revision: D75489849
Differential Revision: D75489873
Differential Revision: D75489887
Raahul46
force-pushed
the
export-D75489895
branch
from
28d3cc1 to
d5b59be
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…ne (pytorch#4227) Summary: X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Reviewed By: duduyi2013 Differential Revision: D75489895
Raahul46
force-pushed
the
export-D75489895
branch
from
d5b59be to
0fe3a05
Compare
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…ne (pytorch#4227) Summary: X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Reviewed By: duduyi2013 Differential Revision: D75489895
Raahul46
force-pushed
the
export-D75489895
branch
from
0fe3a05 to
fbe232a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D75489895 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D75489895 |
Raahul46
pushed a commit
to Raahul46/FBGEMM-1
that referenced
this pull request
Jun 5, 2025
…ne (pytorch#4227) Summary: Pull Request resolved: pytorch#4227 X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Reviewed By: duduyi2013 Differential Revision: D75489895
Raahul46
force-pushed
the
export-D75489895
branch
from
fbe232a to
5c893ca
Compare
…ne (pytorch#4227) Summary: Pull Request resolved: pytorch#4227 X-link: facebookresearch/FBGEMM#1304 Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54 Context: We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold In this diff: 1. We expose serialization and deserialization support through EmbeddingRocksDBWrapper 2. Added a function to generate logs when reading through EmbeddingRocksDB/ReadOnlyEmbeddingKVDB Reviewed By: duduyi2013 Differential Revision: D75489895
|
This pull request was exported from Phabricator. Differential Revision: D75489895 |
Raahul46
force-pushed
the
export-D75489895
branch
from
5c893ca to
9adb4e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1304
Design doc: https://docs.google.com/document/d/149LdAEHOLP7ei4hwVVkAFXGa4N9uLs1J7efxfBZp3dY/edit?tab=t.0#heading=h.49t3yfaqmt54
Context:
We are enabling the usage of rocksDB checkpoint feature in KVTensorWrapper. This allows us to create checkpoints of the embedding tables in SSD. Later, these checkpoints are used by the checkpointing component to create a checkpoint and upload it it to the manifold
In this diff:
Differential Revision: D75489895