Skip to content

Create a system to define Int8 Calibrators that are written in python #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
narendasan opened this issue May 15, 2020 · 8 comments
Closed
Labels
component: api [Python] Issues re: Python API feature request New feature or request priority: low Will be handled, but not in the near term
Milestone

Comments

@narendasan
Copy link
Collaborator

We either need to make the Python Int8Calibrator class from TensorRT compatible with TRTorch or we need to create a system that can bridge the gap.

@narendasan narendasan added priority: low Will be handled, but not in the near term component: api [Python] Issues re: Python API labels May 15, 2020
@github-actions
Copy link

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@narendasan narendasan added this to the v0.2.0 milestone Jul 20, 2020
@github-actions
Copy link

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@narendasan narendasan added feature request New feature or request and removed No Activity labels Dec 4, 2020
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

This issue has not seen activity for 30 days, Remove stale label or comment or this will be closed in 5 days

@narendasan
Copy link
Collaborator Author

Supported in master now

mfeliz-cruise added a commit to mfeliz-cruise/Torch-TensorRT that referenced this issue Oct 6, 2022
# Description

Remove incorrect cast to float in the floor_divide converter that created type-mismatches between the converted and original models.

Fixes # (https://jira.robot.car/browse/MLA-6918)

## Type of change

Please delete options that are not relevant and/or add your own.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

# Checklist:

- [ ] My code follows the style guidelines of this project (You can use the linters)
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to verify my fix or my feature
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified
gs-olive pushed a commit to gs-olive/TensorRT that referenced this issue Oct 11, 2022
# Description

Remove incorrect cast to float in the floor_divide converter that created type-mismatches between the converted and original models.

Fixes # (https://jira.robot.car/browse/MLA-6918)

## Type of change

Please delete options that are not relevant and/or add your own.

- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- This change requires a documentation update

# Checklist:

- [ ] My code follows the style guidelines of this project (You can use the linters)
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas and hacks
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests to verify my fix or my feature
- [ ] New and existing unit tests pass locally with my changes
- [ ] I have added the relevant labels to my PR in so that relevant reviewers are notified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: api [Python] Issues re: Python API feature request New feature or request priority: low Will be handled, but not in the near term
Projects
None yet
Development

No branches or pull requests

1 participant