Skip to content

fix: Avoid resolving non-tensor inputs to torch segment_blocks when unnecessary #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mfeliz-cruise
Copy link
Contributor

@mfeliz-cruise mfeliz-cruise commented May 3, 2022

Description

See issue below for detailed description of the original bug. This change modifies resolveNonTensorInputs to avoid resolving non-tensor inputs to torch blocks unnecessarily that are generated by torch blocks. Unit test added to resolve_non_tensor_inputs.cpp.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@mfeliz-cruise mfeliz-cruise force-pushed the michael.feliz/resolve_non_tensor_inputs_fix branch from ad82166 to 548505b Compare May 3, 2022 18:31
@mfeliz-cruise mfeliz-cruise force-pushed the michael.feliz/resolve_non_tensor_inputs_fix branch from 548505b to 58df59a Compare May 3, 2022 18:43
@narendasan narendasan requested review from bowang007 and peri044 May 3, 2022 20:50
@narendasan narendasan linked an issue May 3, 2022 that may be closed by this pull request
Signed-off-by: Michael Feliz <[email protected]>
@bowang007
Copy link
Collaborator

LGTM. Just need to resolve conflicts.

@narendasan
Copy link
Collaborator

Closing in favor of #1032 which has the conflict resolution as well

@narendasan narendasan closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] KeyError after resolveNonTensorInputs
3 participants