Skip to content

feat: torchtrtc using atol and rtol for tolerance test #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented May 9, 2022

Signed-off-by: Anurag Dixit [email protected]

Description

Added rtol + atol tolerance check for torchtrtc. Similar to what we have for test benchmarks.

Fixes # (issue)
#1030

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@andi4191 andi4191 requested a review from narendasan May 9, 2022 18:15
@andi4191 andi4191 self-assigned this May 9, 2022
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think theres a threshold CLI argument we need to change as well

@andi4191
Copy link
Contributor Author

andi4191 commented May 9, 2022

I think theres a threshold CLI argument we need to change as well

We still need this threshold value for comparison. Is this what you are referring to?
https://github.com/NVIDIA/Torch-TensorRT/blob/master/cpp/bin/torchtrtc/main.cpp#L124

OR

do you want the atol and rtol to be configurable using CLI as well?

@narendasan
Copy link
Collaborator

I think both should be configurable

@andi4191
Copy link
Contributor Author

Closing this PR as it was created from my fork instead.
PR for this feature can be tracked here: #1052

@andi4191 andi4191 closed this May 10, 2022
@andi4191 andi4191 deleted the anuragd/torchtrtc_atol_rtol branch May 10, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants