Skip to content

fix: Upgrade release/1.4 to Torch 2.0.1 + TensorRT 8.6.1 #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2023
Merged

fix: Upgrade release/1.4 to Torch 2.0.1 + TensorRT 8.6.1 #1896

merged 3 commits into from
May 19, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 8, 2023

Description

  • Upgrade to Torch 2.0.1 and TensorRT 8.6.1, latest stable versions
  • Update documentation accordingly, as well as WORKSPACE files and builds
  • Cherry-pick Docker fixes into release branch

Fixes #1895

Type of change

  • Dependency version upgrades

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ - ] I have added tests to verify my fix or my feature
    • CI testing
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

gs-olive added 2 commits May 8, 2023 12:14
@gs-olive
fix: Upgrade versions to latest Torch, TensorRT
3826b58 
- Upgrade to Torch 2.0.1 and TensorRT 8.6.1, latest stable versions
- Update documentation accordingly, as well as WORKSPACE files and
builds
@gs-olive
fix: Improve Docker build robustness, add validation (#1873)
3575478
@gs-olive gs-olive requested a review from narendasan May 8, 2023 21:24
@gs-olive gs-olive self-assigned this May 8, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: build system Issues re: Build system component: fx labels May 8, 2023
@github-actions github-actions bot requested a review from yinghai May 8, 2023 21:24
github-actions[bot]
github-actions bot approved these changes May 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes May 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 8, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@gs-olive gs-olive added the release: v1.4 Tagged to be included in v1.4 label May 8, 2023
@gs-olive gs-olive linked an issue May 8, 2023 that may be closed by this pull request
Upgrade release/1.4 to Torch 2.0.1 + TensorRT 8.6.1 #1895
Closed
@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label May 9, 2023
@github-actions github-actions bot requested a review from wushirong May 9, 2023 01:24
@gs-olive gs-olive removed request for yinghai and wushirong May 9, 2023 16:25
@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label May 19, 2023
github-actions[bot]
github-actions bot approved these changes May 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes May 19, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@gs-olive gs-olive merged commit 93f4be4 into release/1.4 May 19, 2023
@gs-olive gs-olive deleted the release/1.4_version_upgrades branch May 19, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: fx fx release: v1.4 Tagged to be included in v1.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade release/1.4 to Torch 2.0.1 + TensorRT 8.6.1
2 participants
@gs-olive @facebook-github-bot