Skip to content

DLFW changes #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2023
Merged

DLFW changes #2397

merged 3 commits into from
Dec 12, 2023

Conversation

apbose
Copy link
Collaborator

@apbose apbose commented Oct 13, 2023

These are the changes which need to go to main for DLFW.

@apbose apbose marked this pull request as draft October 13, 2023 17:57
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-10-13 17:57:21.760113+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-10-13 18:00:08.358080+00:00
@@ -230,13 +230,11 @@


def run_dynamo_lower_tests(session):
    print("Running Dynamo lowering passes")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "lowering"
-    ]
+    tests = ["lowering"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)
@@ -256,13 +254,11 @@


def run_dynamo_partitioning_tests(session):
    print("Running Dynamo Partitioning tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "partitioning"
-    ]
+    tests = ["partitioning"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-11-13 19:28:54.486632+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-11-13 19:30:39.455400+00:00
@@ -230,26 +230,22 @@


def run_dynamo_lower_tests(session):
    print("Running Dynamo lowering passes")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "lowering"
-    ]
+    tests = ["lowering"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)


def run_dynamo_partitioning_tests(session):
    print("Running Dynamo Partitioning tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "partitioning"
-    ]
+    tests = ["partitioning"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)
@@ -274,25 +270,30 @@
    tests = [
        "test_models.py",
    ]
    for test in tests:
        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("torch_compile"), env={"PYTHONPATH": PYT_PATH})
+            session.run_always(
+                "python",
+                test,
+                "--ir",
+                str("torch_compile"),
+                env={"PYTHONPATH": PYT_PATH},
+            )
        else:
            session.run_always("python", test, "--ir", str("torch_compile"))


def run_dynamo_model_export_tests(session):
    print("Running model torch-export tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/models"))
-    tests = [
-        "test_models_export.py",
-        "test_export_serde.py"
-    ]
-    for test in tests:
-        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH})
+    tests = ["test_models_export.py", "test_export_serde.py"]
+    for test in tests:
+        if USE_HOST_DEPS:
+            session.run_always(
+                "python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH}
+            )
        else:
            session.run_always("python", test, "--ir", str("dynamo"))


def run_accuracy_tests(session):

@apbose apbose requested a review from narendasan November 13, 2023 19:31
@apbose apbose marked this pull request as ready for review November 13, 2023 19:31
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-11-13 19:31:29.299582+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-11-13 19:34:23.265494+00:00
@@ -230,26 +230,22 @@


def run_dynamo_lower_tests(session):
    print("Running Dynamo lowering passes")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "lowering"
-    ]
+    tests = ["lowering"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)


def run_dynamo_partitioning_tests(session):
    print("Running Dynamo Partitioning tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "partitioning"
-    ]
+    tests = ["partitioning"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)
@@ -274,25 +270,30 @@
    tests = [
        "test_models.py",
    ]
    for test in tests:
        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("torch_compile"), env={"PYTHONPATH": PYT_PATH})
+            session.run_always(
+                "python",
+                test,
+                "--ir",
+                str("torch_compile"),
+                env={"PYTHONPATH": PYT_PATH},
+            )
        else:
            session.run_always("python", test, "--ir", str("torch_compile"))


def run_dynamo_model_export_tests(session):
    print("Running model torch-export tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/models"))
-    tests = [
-        "test_models_export.py",
-        "test_export_serde.py"
-    ]
-    for test in tests:
-        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH})
+    tests = ["test_models_export.py", "test_export_serde.py"]
+    for test in tests:
+        if USE_HOST_DEPS:
+            session.run_always(
+                "python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH}
+            )
        else:
            session.run_always("python", test, "--ir", str("dynamo"))


def run_accuracy_tests(session):

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-11-13 19:31:41.368196+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-11-13 19:34:36.750593+00:00
@@ -230,26 +230,22 @@


def run_dynamo_lower_tests(session):
    print("Running Dynamo lowering passes")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "lowering"
-    ]
+    tests = ["lowering"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)


def run_dynamo_partitioning_tests(session):
    print("Running Dynamo Partitioning tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "partitioning"
-    ]
+    tests = ["partitioning"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)
@@ -274,25 +270,30 @@
    tests = [
        "test_models.py",
    ]
    for test in tests:
        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("torch_compile"), env={"PYTHONPATH": PYT_PATH})
+            session.run_always(
+                "python",
+                test,
+                "--ir",
+                str("torch_compile"),
+                env={"PYTHONPATH": PYT_PATH},
+            )
        else:
            session.run_always("python", test, "--ir", str("torch_compile"))


def run_dynamo_model_export_tests(session):
    print("Running model torch-export tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/models"))
-    tests = [
-        "test_models_export.py",
-        "test_export_serde.py"
-    ]
-    for test in tests:
-        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH})
+    tests = ["test_models_export.py", "test_export_serde.py"]
+    for test in tests:
+        if USE_HOST_DEPS:
+            session.run_always(
+                "python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH}
+            )
        else:
            session.run_always("python", test, "--ir", str("dynamo"))


def run_accuracy_tests(session):

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-12-12 18:45:39.561039+00:00
+++ /home/runner/work/TensorRT/TensorRT/noxfile.py	2023-12-12 18:47:30.844630+00:00
@@ -230,26 +230,22 @@


def run_dynamo_lower_tests(session):
    print("Running Dynamo lowering passes")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "lowering"
-    ]
+    tests = ["lowering"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)


def run_dynamo_partitioning_tests(session):
    print("Running Dynamo Partitioning tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/"))
-    tests = [
-        "partitioning"
-    ]
+    tests = ["partitioning"]
    for test in tests:
        if USE_HOST_DEPS:
            session.run_always("pytest", test, env={"PYTHONPATH": PYT_PATH})
        else:
            session.run_always("pytest", test)
@@ -274,25 +270,30 @@
    tests = [
        "test_models.py",
    ]
    for test in tests:
        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("torch_compile"), env={"PYTHONPATH": PYT_PATH})
+            session.run_always(
+                "python",
+                test,
+                "--ir",
+                str("torch_compile"),
+                env={"PYTHONPATH": PYT_PATH},
+            )
        else:
            session.run_always("python", test, "--ir", str("torch_compile"))


def run_dynamo_model_export_tests(session):
    print("Running model torch-export tests")
    session.chdir(os.path.join(TOP_DIR, "tests/py/dynamo/models"))
-    tests = [
-        "test_models_export.py",
-        "test_export_serde.py"
-    ]
-    for test in tests:
-        if USE_HOST_DEPS:
-            session.run_always("python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH})
+    tests = ["test_models_export.py", "test_export_serde.py"]
+    for test in tests:
+        if USE_HOST_DEPS:
+            session.run_always(
+                "python", test, "--ir", str("dynamo"), env={"PYTHONPATH": PYT_PATH}
+            )
        else:
            session.run_always("python", test, "--ir", str("dynamo"))


def run_accuracy_tests(session):

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 87fc615 into main Dec 12, 2023
@narendasan narendasan deleted the DLFW_main_changes branch December 12, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants