-
Notifications
You must be signed in to change notification settings - Fork 365
feat: Add hardware compatibility option in Dynamo #2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
445eb56
to
0404ee4
Compare
437151a
to
f76e8f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine, but have we tested this with torchscript to make sure nothing breaks there?
Currently, there is a Torchscript test which loads a hardware-compatible |
Will torchscript be able to create new engines using this API since the signature changed right? Is is just default not compatible? |
Yes, the signature changed and the ABI version was bumped. For compatibility with older compiled engines (like ABI 4), would there be a way to just assume |
Im not talking about old engines since they will not work with the bumped ABI. But like if I do torch_tensorrt.ts.compile() will this work properly? |
I see - currently, |
4aaf9f9
to
74e24a4
Compare
- Add support for hardware compatibility for Ampere and later architectures - Add necessary functions to support the modification throughout the stack, including C++ and Python components - Update ABI version to address new metadata format for TRT Engines - Update engine serialization schema accordingly - Add test cases to validate feature
74e24a4
to
7c5af4d
Compare
Description
Fixes #1929
Addresses #1888
Type of change
Checklist: