Skip to content

feat: support aten.scalar_tensor dynamo converter #2595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2024
Merged

feat: support aten.scalar_tensor dynamo converter #2595

merged 4 commits into from
Jan 23, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Support aten.scalar_tensor dynamo converter.

Fixes #2593

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jan 15, 2024
@github-actions github-actions bot requested a review from narendasan January 15, 2024 10:42
@zewenli98 zewenli98 self-assigned this Jan 16, 2024
@zewenli98 zewenli98 force-pushed the scalar_tensor_dynamo_converter branch from 20620a9 to fcfac7a Compare January 17, 2024 11:53
@zewenli98 zewenli98 requested a review from gs-olive January 17, 2024 11:54
gs-olive
gs-olive approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small comment, looks good otherwise pending CI!

@zewenli98 zewenli98 force-pushed the scalar_tensor_dynamo_converter branch from 8b7ff5f to f720276 Compare January 19, 2024 18:20
@zewenli98 zewenli98 merged commit e642f86 into pytorch:main Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gs-olive gs-olive gs-olive approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@bowang007 bowang007 Awaiting requested review from bowang007

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aten.scalar_tensor
3 participants
@zewenli98 @gs-olive @facebook-github-bot