Skip to content

fix: update tests of pooling converters #2613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix: update tests of pooling converters #2613

merged 1 commit into from
Feb 15, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

Update tests of pooling converters.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Jan 21, 2024
@github-actions github-actions bot added the component: tests Issues re: Tests label Jan 21, 2024
@github-actions github-actions bot requested a review from narendasan January 21, 2024 05:38
@zewenli98 zewenli98 added component: converters Issues re: Specific op converters and removed component: tests Issues re: Tests labels Jan 21, 2024
@github-actions github-actions bot requested a review from apbose January 21, 2024 05:38
@zewenli98 zewenli98 requested a review from bowang007 February 2, 2024 18:38
@zewenli98 zewenli98 force-pushed the fix_pool_dynamo_converter branch from c809343 to 6bc63ae Compare February 9, 2024 01:03
@github-actions github-actions bot added component: tests Issues re: Tests and removed component: converters Issues re: Specific op converters labels Feb 9, 2024
bowang007
bowang007 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@bowang007 bowang007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@zewenli98 zewenli98 merged commit fb07513 into pytorch:main Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowang007 bowang007 bowang007 approved these changes

@narendasan narendasan Awaiting requested review from narendasan

@apbose apbose Awaiting requested review from apbose

Assignees

@zewenli98 zewenli98

Labels
cla signed component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zewenli98 @bowang007 @facebook-github-bot