Skip to content

fix: Add write permissions to Docker GHA #2619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2024
Merged

fix: Add write permissions to Docker GHA #2619

merged 1 commit into from
Jan 23, 2024

Conversation

gs-olive
Copy link
Collaborator

Description

  • Fix Docker build job on GHA

Type of change

  • Infra fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Jan 23, 2024
@gs-olive gs-olive mentioned this pull request Jan 23, 2024
Merged
huydhn
huydhn approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I guess we need to try this out to see if this work

@gs-olive gs-olive merged commit eb62a3d into main Jan 23, 2024
@gs-olive gs-olive deleted the docker_build_permissions branch January 23, 2024 20:51
gs-olive added a commit that referenced this pull request Jan 31, 2024
@gs-olive
fix: Add write permissions to Docker GHA (#2619)
f9cbfc3
@gs-olive gs-olive mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @huydhn @facebook-github-bot