Skip to content

feat: support converter for torch.log10 #2621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

feat: support converter for torch.log10 #2621

merged 1 commit into from
Mar 4, 2024

Conversation

bowang007
Copy link
Collaborator

@bowang007 bowang007 commented Jan 23, 2024 •
edited
Loading

Description

support converter for torch.log10

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jan 23, 2024
zewenli98
zewenli98 reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just need some minor changes.

github-actions[bot]
github-actions bot requested changes Jan 30, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited by bowang007
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated

github-actions[bot]
github-actions bot requested changes Feb 2, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited by bowang007
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outdated.

gs-olive
gs-olive approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bowang007 bowang007 merged commit ab08c63 into main Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

@gs-olive gs-olive gs-olive approved these changes

@apbose apbose Awaiting requested review from apbose

@narendasan narendasan Awaiting requested review from narendasan

@peri044 peri044 Awaiting requested review from peri044

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bowang007 @zewenli98 @gs-olive @facebook-github-bot