Skip to content

TRT-10 GA Support for release/2.3 branch #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2024
Merged

TRT-10 GA Support for release/2.3 branch #2778

merged 4 commits into from
Apr 26, 2024

Conversation

zewenli98
Copy link
Collaborator

Description

This PR runs CI to test TRT-10 GA support for release/2.3 branch.

@zewenli98 zewenli98 added the WIP Work is in progress, pull request should not be merged yet label Apr 25, 2024
@zewenli98 zewenli98 self-assigned this Apr 25, 2024
@github-actions github-actions bot added component: build system Issues re: Build system component: api [Python] Issues re: Python API labels Apr 25, 2024
@github-actions github-actions bot requested a review from gs-olive April 25, 2024 22:18
@zewenli98 zewenli98 removed the request for review from gs-olive April 25, 2024 22:18
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: converters Issues re: Specific op converters component: api [C++] Issues re: C++ API component: evaluators Issues re: Specific op evaluators component: runtime component: fx component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile labels Apr 26, 2024
@zewenli98 zewenli98 changed the base branch from release/2.3 to main April 26, 2024 01:59
@zewenli98 zewenli98 changed the base branch from main to release/2.3 April 26, 2024 02:12
@zewenli98 zewenli98 removed documentation Improvements or additions to documentation component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler labels Apr 26, 2024
@zewenli98 zewenli98 removed component: converters Issues re: Specific op converters component: evaluators Issues re: Specific op evaluators component: runtime component: fx component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile labels Apr 26, 2024
@zewenli98 zewenli98 requested a review from peri044 April 26, 2024 18:21
@zewenli98 zewenli98 removed the WIP Work is in progress, pull request should not be merged yet label Apr 26, 2024
@zewenli98 zewenli98 changed the title [WIP] TRT-10 GA Support for release/2.3 branch TRT-10 GA Support for release/2.3 branch Apr 26, 2024
peri044
peri044 reviewed Apr 26, 2024
View reviewed changes
peri044
peri044 requested changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change. Overall LGTM

@peri044
Copy link
Collaborator

peri044 commented Apr 26, 2024

Can you add tensorrt==10.0.1.6 in our py/requirements.txt ? (https://github.com/pytorch/TensorRT/blob/trt_10_ga_cloned_from_main/py/requirements.txt)
Also update trt version in dev_dep_versions.yml (https://github.com/pytorch/TensorRT/blob/trt_10_ga_cloned_from_main/dev_dep_versions.yml)

@github-actions github-actions bot removed the component: api [C++] Issues re: C++ API label Apr 26, 2024
@zewenli98 zewenli98 requested a review from peri044 April 26, 2024 18:54
peri044
peri044 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will generate a hw_compat.ts in a separate PR.

@peri044 peri044 merged commit 249280d into release/2.3 Apr 26, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

Assignees

@zewenli98 zewenli98

Labels
cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zewenli98 @peri044 @facebook-github-bot