Skip to content

cherry pick pull/2879 to release/2.3 branch #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024
Merged

cherry pick pull/2879 to release/2.3 branch #2882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion py/torch_tensorrt/dynamo/conversion/impl/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,12 @@ def embedding_bag_with_traversable_offsets(
# however, pytorch doc says if `include_last_offset` is True, the size of offsets
# is equal to the number of bags + 1. The last element is the size of the input,
# or the ending index position of the last bag (sequence).
offsets.itemset(-1, len_embed)
# Notes: here offsets should always be 1d array
if len(offsets.shape) != 1:
raise TypeError(
f"The offsets should be in 1d array, here offset shape is {offsets.shape}."
)
offsets[-1] = len_embed
else:
# add the end index to offsets
offsets = np.append(offsets, len_embed)
Expand Down
Loading