Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support flashinfer.rmsnorm #3424

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Support flashinfer.rmsnorm #3424

wants to merge 1 commit into from

Conversation

bowang007
Copy link
Collaborator

This PR resolves some issues and support flashinfer.rmsnorm

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 4, 2025
@github-actions github-actions bot requested a review from peri044 March 4, 2025 07:41
github-actions[bot]

This comment was marked as outdated.

Sign in to view

@bowang007 bowang007 marked this pull request as draft March 4, 2025 07:41
@bowang007 bowang007 self-assigned this Mar 4, 2025
@bowang007 bowang007 marked this pull request as ready for review March 4, 2025 20:34
@bowang007 bowang007 changed the title test: Support flashinfer.rmsnorm feat: Support flashinfer.rmsnorm Mar 4, 2025
@narendasan
Copy link
Collaborator

@bowang007 Can you move the auto plugin gen tests to a runner other than the one used for converter tests?

peri044
peri044 reviewed Mar 21, 2025
View reviewed changes
@github-actions github-actions bot requested a review from narendasan April 8, 2025 21:12
@bowang007 bowang007 force-pushed the flashinfer_rmsnorm branch from 3cc6ecb to aed7cb1 Compare April 10, 2025 23:32
@bowang007 bowang007 requested review from peri044 and zewenli98 April 10, 2025 23:32
narendasan
narendasan reviewed Apr 11, 2025
View reviewed changes
tests/py/dynamo/automatic_plugin/test_flashinfer_rmsnorm.py
)


class TestAutomaticPlugin(DispatchTestCase):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip if flash infer not installed

zewenli98
zewenli98 reviewed Apr 11, 2025
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like flashiner-python installation is problematic on CI. After resolving this issue, can you also check if this works for python 3.13 because we are going to support 3.13 as of 2.7 release while some packages may not be available for 3.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@zewenli98 zewenli98 zewenli98 left review comments

@github-actions github-actions[bot] github-actions[bot] requested changes

@chohk88 chohk88 Awaiting requested review from chohk88

@apbose apbose Awaiting requested review from apbose

@cehongwang cehongwang Awaiting requested review from cehongwang

@peri044 peri044 Awaiting requested review from peri044

Assignees

@bowang007 bowang007

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests needs-release-cherrypick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bowang007 @narendasan @peri044 @zewenli98 @facebook-github-bot @Christina-Young-NVIDIA