fix: nightly build python versions #3426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zewenli98
force-pushed
the
fix_nightly_build
branch
4 times, most recently
from
de653c7 to
1ca0f01
Compare
zewenli98
force-pushed
the
fix_nightly_build
branch
from
1ca0f01 to
d675dc0
Compare
peri044
approved these changes
Mar 6, 2025
| @@ -23,7 +23,7 @@ jobs: | |||
| test-infra-ref: main | |||
| with-rocm: false | |||
| with-cpu: false | |||
| python-versions: '["3.11"]' | |||
| python-versions: '["3.11", "3.12", "3.10", "3.9"]' | |||
There was a problem hiding this comment.
minor thing : consider changing the order to '["3.9", "3.10", "3.11", "3.12"]'
narendasan
approved these changes
Mar 6, 2025
|
@peri044 @narendasan yeah, I did this on purpose because it gets the first entry to run CI for the PR. Changing to '["3.9", "3.10", "3.11", "3.12"]' would make every PR run with py3.9 instead of py3.11. I think we agreed that 3.11 should be default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3425
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: