feat: rmsnorm lowering #3440
Open
feat: rmsnorm lowering #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: lowering
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
narendasan
reviewed
Mar 13, 2025
narendasan
reviewed
Mar 13, 2025
py/torch_tensorrt/dynamo/lowering/passes/_aten_lowering_pass.py
Outdated
Show resolved
Hide resolved
github-actions
bot
added
component: conversion
bowang007
requested review from
peri044 and
zewenli98
and removed request for
gs-olive
zewenli98
reviewed
Apr 11, 2025
| shape_calc_fns = [None] * output.ndim | ||
|
|
||
| for i in range(output.ndim): | ||
| input_node_expr = input_node_expr = list( |
| shape_calc_fns = [None] * args[0].ndim | ||
| for i in range(args[0].ndim): | ||
| input_node_expr = [syms_arg[i].node.expr for syms_arg in syms_args] | ||
| shape_calc_fns = [None] * output.ndim |
There was a problem hiding this comment.
It looks like fake_mode above was defined twice.
narendasan
reviewed
Apr 11, 2025
| tensor_inputs = plugin.input_tensor_names | ||
| tensor_args = args[0 : len(tensor_inputs)] | ||
|
|
||
| random_id = random.randint(0, 10000) |
There was a problem hiding this comment.
Use UUID (as short as possible) instead of random for now
narendasan
reviewed
Apr 11, 2025
| torch_tensorrt.dynamo.conversion.plugins.custom_op( | ||
| "flashinfer::rmsnorm", supports_dynamic_shapes=True | ||
| ) | ||
|
|
There was a problem hiding this comment.
TODO: After merge, extend this example to include an aot_impl
There was a problem hiding this comment.
There needs to be a modification to the plugin_converter generation that figure out if you can use aot_impl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RMSNORM lowering pass
Checklist: