Skip to content

add a quick fail fast feed-back actions before the full tests is triggered #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

#3501

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review May 30, 2025 16:25
@github-actions github-actions bot added the component: tests Issues re: Tests label May 30, 2025
@lanluo-nvidia lanluo-nvidia requested a review from narendasan May 30, 2025 16:25
@github-actions github-actions bot added the component: build system Issues re: Build system label Jun 2, 2025
@lanluo-nvidia lanluo-nvidia self-assigned this Jun 4, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to Python style guidelines:

--- /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/partitioning/test_fast_partitioning.py	2025-06-04 17:57:24.987469+00:00
+++ /home/runner/work/TensorRT/TensorRT/tests/py/dynamo/partitioning/test_fast_partitioning.py	2025-06-04 17:57:55.095353+00:00
@@ -82,10 +82,11 @@
                ]
            ),
            1,
            "All operators are supported, there should be one segment",
        )
+
    @pytest.mark.critical
    def test_partition_partially_supported_multi_op(self):
        class PartiallySupportedMultiOp(torch.nn.Module):
            def __init__(self, *args, **kwargs) -> None:
                super().__init__(*args, **kwargs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: build system Issues re: Build system component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants