Add support for copy_ for plain layout and tensor core tiled layout #1791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1791
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 0885a49 with merge base 1ab1b77 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
added
the
topic: improvement
drisspg
reviewed
Feb 27, 2025
drisspg
approved these changes
Feb 27, 2025
Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags:
|
@jerryzh168 This broke ROCm CI: https://hud.pytorch.org/pytorch/ao/commit/79e3366e273dcc50e0300384a1d0d6b1cc8d5e1f I'm not sure if we plan to follow the same approach as we do in the PyTorch project of reverting and relanding PRs that break ROCm CI. But if we do, please revert this PR and add the |
drisspg
pushed a commit
that referenced
this pull request
Feb 28, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support
drisspg
pushed a commit
that referenced
this pull request
Feb 28, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
drisspg
pushed a commit
that referenced
this pull request
Mar 4, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
drisspg
pushed a commit
that referenced
this pull request
Mar 5, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
drisspg
pushed a commit
that referenced
this pull request
Mar 5, 2025
…1791) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40
drisspg
added a commit
that referenced
this pull request
Mar 5, 2025
…1791) (#1804) * Add support for copy_ for plain layout and tensor core tiled layout Summary: att, only support copy_ from AQT to another AQT with same metadata (shapes etc.) Tested int4wo, int8wo, int8dq Test Plan: python test/dtypes/test_affine_quantized.py -k test_copy_ Reviewers: Subscribers: Tasks: Tags: * remove print * add metadata mismatch test * rebase and add float8 * cutlass int4 support stack-info: PR: #1804, branch: drisspg/stack/40 Co-authored-by: Jerry Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
att, only support copy_ from AQT to another AQT with same metadata (shapes etc.)
Tested int4wo, int8wo, int8dq
This is to support the
param.data.copy_usage in vllm/sglangTest Plan:
python test/dtypes/test_affine_quantized.py -k test_copy_
Reviewers:
Subscribers:
Tasks:
Tags: