enable mxfp8_cublas recipe in roofline script #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
This was referenced Mar 5, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1843
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vkuzo
added a commit
that referenced
this pull request
Mar 5, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2da390c ghstack-comment-id: 2701761490 Pull Request resolved: #1843
vkuzo
added a commit
that referenced
this pull request
Mar 5, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ea3dda7 ghstack-comment-id: 2701761490 Pull Request resolved: #1843
vkuzo
added
the
topic: not user facing
vkuzo
added a commit
that referenced
this pull request
Mar 5, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: a26ad14 ghstack-comment-id: 2701761490 Pull Request resolved: #1843
vkuzo
added a commit
that referenced
this pull request
Mar 5, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1e5a431 ghstack-comment-id: 2701761490 Pull Request resolved: #1843
vkuzo
added a commit
that referenced
this pull request
Mar 5, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: c4c0cd3 ghstack-comment-id: 2701761490 Pull Request resolved: #1843
vkuzo
added a commit
that referenced
this pull request
Mar 6, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 829d32d ghstack-comment-id: 2701761490 Pull Request resolved: #1843
danielvegamyhre
approved these changes
Mar 7, 2025
vkuzo
added a commit
that referenced
this pull request
Mar 11, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: bcf98e4 ghstack-comment-id: 2701761490 Pull Request resolved: #1843
vkuzo
added a commit
that referenced
this pull request
Mar 11, 2025
Summary: Enables us to see roofline vs actual performance of this recipe Test Plan: ``` python benchmarks/float8/float8_roofline.py ~/local/tmp/20250305_test --mx_recipe_name mxfp8_cublas ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: bcf98e4 ghstack-comment-id: 2701761490 Pull Request resolved: #1843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables us to see roofline vs actual performance of this recipe
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: