Skip to content

fix typing annotation #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix typing annotation #1849

merged 1 commit into from
Mar 7, 2025

Conversation

mayank31398
Copy link
Contributor

@mayank31398 mayank31398 commented Mar 7, 2025 •
edited
Loading

fixes a minor annotation in the typing

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1849

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 10 Pending, 1 Unrelated Failure

As of commit ce8c4c3 with merge base ff335a5 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @mayank31398!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@mayank31398
fix type
ce8c4c3 
Signed-off-by: Mayank Mishra <[email protected]>

signed CLA

Signed-off-by: Mayank Mishra <[email protected]>
@msaroufim msaroufim self-requested a review March 7, 2025 03:00
@msaroufim msaroufim added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Mar 7, 2025
@msaroufim msaroufim merged commit 24c966c into pytorch:main Mar 7, 2025
16 of 18 checks passed
@mayank31398 mayank31398 deleted the fix-type branch March 7, 2025 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaroufim msaroufim msaroufim approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank31398 @facebook-github-bot @msaroufim