Add dynamic shape support for lowbit kernels #1942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1942
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 11 PendingAs of commit 6ca7454 with merge base 3fb1665 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jackzhxng
approved these changes
Mar 24, 2025
jackzhxng
reviewed
Mar 24, 2025
| k1 = 256 | ||
| k2 = 128 | ||
| k3 = 1024 | ||
| weight_dtype = torch.int4 |
There was a problem hiding this comment.
Maybe would be good to loop through and test all of the possible granularities from 2-7
jackzhxng
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support dynamic shapes, the linear/embedding meta kernels must be written in python.
The packing meta kernels are still in C++ because 1) packing shapes are not dynamic, and 2) the packed size is not readily available in python. For these, I move to create meta tensors directly per #1936.