Clean extension.py #1460
Merged
Clean extension.py #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1460
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8cb73ff with merge base 83d09ff ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
divyanshk
reviewed
Mar 2, 2025
| without_abi = ext_filename_parts[:-2] + ext_filename_parts[-1:] | ||
| ext_filename = ".".join(without_abi) | ||
| return ext_filename | ||
| return [] |
There was a problem hiding this comment.
I don't know about this, can we check if we need to keep get_ext_modules ?
|
@ramanishsingh this is good to go!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1451