Skip to content

Further Runner and Module improvements. #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Further Runner and Module improvements. #1622

wants to merge 2 commits into from

Conversation

shoumikhin
Copy link
Contributor

Summary:

  • Init runtime in constructor
  • Allow injecting event tracer
  • Allow providing verification mode at load
  • Utilize check and unwrap macros for brevity

Differential Revision: D52846711

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 17, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1622

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c835e5 with merge base 6aab49e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

22 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

shoumikhin and others added 2 commits January 19, 2024 10:04
@shoumikhin @facebook-github-bot
Macros to check and return if error. (#1621)
c9c57b8 
Summary:
Pull Request resolved: #1621

.

Differential Revision: https://internalfb.com/D52846710

fbshipit-source-id: fc3c0936db76c600416fc274714b8c7a0ab47133
@shoumikhin @facebook-github-bot
Further Module improvements. (#1622)
5c835e5 
Summary:
Pull Request resolved: #1622

- Merge Runner and Module
- Init runtime in constructor
- Allow injecting event tracer
- Allow providing verification mode at load
- Utilize check and unwrap macros for brevity

Reviewed By: dbort

Differential Revision: D52846711

fbshipit-source-id: c7510f7ae3aa4394a4b0667261dd6b11452ffbc5
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52846711

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 4da94a9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoumikhin @facebook-github-bot